Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings validation and cascade deletion #1798

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Sep 24, 2024

DB

  • Setup cascade delete: deleting a user also deletes their settings (note: this action is not exposed in the API)

API

  • It seems that the /auth/users/{user_id}/settings endpoint accepts empty strings in the SLURM accounts array: slurm_accounts: [""]

Task-collection and job-execution API

  • Let's add slurm_accounts: list[str] to the required and validated settings, both for sudo and ssh slurm backends

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco changed the title validate UserSettingsUpdate.slurm_accounts Settings validation and cascade deletion Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app
  user_settings.py
  fractal_server/app/routes/aux
  validate_user_settings.py
  fractal_server/app/schemas
  user_settings.py 70
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 3341841 into 1774-introduce-user-settings Sep 24, 2024
14 checks passed
@tcompa tcompa deleted the 1774-api-and-cascade branch September 24, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants